Skip to content

libreoffice-fresh: 6.0.3.2 -> 6.0.4.2 and don't use system xmlsec#42156

Merged
7c6f434c merged 2 commits intoNixOS:masterfrom
jokogr:u/libreoffice-fresh-6.0.4.2
Jun 18, 2018
Merged

libreoffice-fresh: 6.0.3.2 -> 6.0.4.2 and don't use system xmlsec#42156
7c6f434c merged 2 commits intoNixOS:masterfrom
jokogr:u/libreoffice-fresh-6.0.4.2

Conversation

@jokogr
Copy link
Contributor

@jokogr jokogr commented Jun 18, 2018

Motivation for this change

I have upgraded libreoffice-fresh to its latest upstream version and noticed that some tests have started to break. NixOS uses apparently a new version of xmlsec and LibreOffice is incompatible with it. As such, the second commit disables it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

I think an update of xmlsec has been rolled back in master, but maybe as it has other uses maybe it is better to use the bundled version.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 18, 2018
@7c6f434c 7c6f434c merged commit 934650e into NixOS:master Jun 18, 2018
@jokogr jokogr deleted the u/libreoffice-fresh-6.0.4.2 branch June 28, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants